Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757744AbZCNWEt (ORCPT ); Sat, 14 Mar 2009 18:04:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754947AbZCNWEf (ORCPT ); Sat, 14 Mar 2009 18:04:35 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:43749 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751238AbZCNWEe (ORCPT ); Sat, 14 Mar 2009 18:04:34 -0400 Date: Sat, 14 Mar 2009 15:04:20 -0700 (PDT) Message-Id: <20090314.150420.149174658.davem@davemloft.net> To: rjw@sisk.pl Cc: linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, bart@jukie.net, netdev@vger.kernel.org Subject: Re: [Bug #12805] QinQ vlan trunking regression From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 44 From: "Rafael J. Wysocki" Date: Sat, 14 Mar 2009 20:05:33 +0100 (CET) > This message has been generated automatically as a part of a report > of recent regressions. > > The following bug entry is on the current list of known regressions > from 2.6.28. Please verify if it still should be listed and let me know > (either way). > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12805 > Subject : QinQ vlan trunking regression > Submitter : Bart Trojanowski > Date : 2009-02-28 18:05 (15 days old) > References : http://marc.info/?l=linux-kernel&m=123584439115868&w=4 Fixed by: commit 9d40bbda599def1e1d155d7f7dca14fe8744bd2b Author: David S. Miller Date: Wed Mar 4 23:46:25 2009 -0800 vlan: Fix vlan-in-vlan crashes. As analyzed by Patrick McHardy, vlan needs to reset it's netdev_ops pointer in it's ->init() function but this leaves the compat method pointers stale. Add a netdev_resync_ops() and call it from the vlan code. Any other driver which changes ->netdev_ops after register_netdevice() will need to call this new function after doing so too. With help from Patrick McHardy. Tested-by: Patrick McHardy Signed-off-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/