Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759072AbZCOKVz (ORCPT ); Sun, 15 Mar 2009 06:21:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755670AbZCOKVp (ORCPT ); Sun, 15 Mar 2009 06:21:45 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:35298 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753652AbZCOKVp (ORCPT ); Sun, 15 Mar 2009 06:21:45 -0400 Date: Sun, 15 Mar 2009 11:23:41 +0100 From: Sam Ravnborg To: linux-kbuild , LKML Cc: Roman Zippel , Ingo Molnar Subject: kconfig - fix randconfig Message-ID: <20090315102341.GA6051@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 43 kconfig failed to generate random values for choice values in a choice block thus limiting the effect of builds based on randconfig generated configs. To test this I used this small config: config MOD def_bool n option modules choice CHOICE prompt "ABCD Choice" default A config A tristate "A" config B tristate "B" config C tristate "C" config D tristate "D" endchoice With the fix applied we now distribute the values more or less even among the choice symbols. And if MOD is enabled then we have several entries enabled. Furhtermore calling randconfig several times in row made it generate the same config as it used a second based seed. Two patches follows - they are also at kfixes.git Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/