Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754434AbZCPCvi (ORCPT ); Sun, 15 Mar 2009 22:51:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752073AbZCPCv2 (ORCPT ); Sun, 15 Mar 2009 22:51:28 -0400 Received: from vms173003pub.verizon.net ([206.46.173.3]:62275 "EHLO vms173003pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbZCPCv1 (ORCPT ); Sun, 15 Mar 2009 22:51:27 -0400 Date: Sun, 15 Mar 2009 22:51:22 -0400 (EDT) From: Len Brown X-X-Sender: lenb@localhost.localdomain To: Henrique de Moraes Holschuh Cc: Mathieu Chouquet-Stringer , Kay Sievers , Linux Kernel Mailing List , Linus Torvalds , ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH] thinkpad-acpi: fix module autoloading for older models In-reply-to: <20090314175538.GA27278@khazad-dum.debian.net> Message-id: References: <20090314104204.GA11226@mobydick> <20090314153526.GA13084@mobydick> <20090314175538.GA27278@khazad-dum.debian.net> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 31 On Sat, 14 Mar 2009, Henrique de Moraes Holschuh wrote: > On Sat, 14 Mar 2009, Mathieu Chouquet-Stringer wrote: > > On Sat, Mar 14, 2009 at 04:14:19PM +0100, Kay Sievers wrote: > > > On Sat, Mar 14, 2009 at 11:42, Mathieu Chouquet-Stringer > > > wrote: > > > > > > > While for older Thinkpads, you do this (for instance): > > > > IBM_BIOS_MODULE_ALIAS("1[0,3,6,8,A-G,I,K,M-P,S,T]"); > > > > > > Aliases are shell-style globs. Any idea what the ',' are doing in a > > > character class? Confused ... > > > > Good point... I guess it's a typo: perhaps the original authors thought > > of it as a brace expansion? Something like 1{0,3,6,...}? > > I bet that's exactly what happened... it was a long time ago, so I don't > recall exactly what I was (not) thinking about when I did it. > > Thanks for noticing this, and the revised patch looks good. revised patch (with commit log from 1st patch) applied. thanks, Len Brown, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/