Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbZCPGcP (ORCPT ); Mon, 16 Mar 2009 02:32:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751435AbZCPGb6 (ORCPT ); Mon, 16 Mar 2009 02:31:58 -0400 Received: from ns.suse.de ([195.135.220.2]:51992 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbZCPGb5 (ORCPT ); Mon, 16 Mar 2009 02:31:57 -0400 Date: Mon, 16 Mar 2009 07:31:53 +0100 Message-ID: From: Takashi Iwai To: Adrian McMenamin Cc: Alsa-devel , LKML , linux-sh Subject: Re: [PATCH] snd: aica - fix annoying compiler warning In-Reply-To: <1237154740.6636.4.camel@localhost.localdomain> References: <1237154740.6636.4.camel@localhost.localdomain> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 34 At Sun, 15 Mar 2009 22:05:40 +0000, Adrian McMenamin wrote: > > Cast pointer to data member of struct firmware as a void to end an > annoying compiler warning. > > fix annoying compiler warning > > Signed-off-by: Adrian McMenamin > --- > > diff --git a/sound/sh/aica.c b/sound/sh/aica.c > index 7c920f3..822b119 100644 > --- a/sound/sh/aica.c > +++ b/sound/sh/aica.c > @@ -567,7 +567,7 @@ static int load_aica_firmware(void) > return err; > /* write firware into memory */ > spu_disable(); > - spu_memload(0, fw_entry->data, fw_entry->size); > + spu_memload(0, (void *)fw_entry->data, fw_entry->size); IMO, it's better to fix spu_memload() to take const pointer instead of cast. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/