Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758079AbZCPLqS (ORCPT ); Mon, 16 Mar 2009 07:46:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752073AbZCPLqD (ORCPT ); Mon, 16 Mar 2009 07:46:03 -0400 Received: from mail.suse.de ([195.135.220.2]:45765 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbZCPLqB (ORCPT ); Mon, 16 Mar 2009 07:46:01 -0400 Date: Mon, 16 Mar 2009 12:45:55 +0100 From: Nick Piggin To: Mel Gorman Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Christoph Lameter , Johannes Weiner , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 00/35] Cleanup and optimise the page allocator V3 Message-ID: <20090316114555.GB30802@wotan.suse.de> References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 24 On Mon, Mar 16, 2009 at 09:45:55AM +0000, Mel Gorman wrote: > Here is V3 of an attempt to cleanup and optimise the page allocator and should > be ready for general testing. The page allocator is now faster (16% > reduced time overall for kernbench on one machine) and it has a smaller cache > footprint (16.5% less L1 cache misses and 19.5% less L2 cache misses for > kernbench on one machine). The text footprint has unfortunately increased, > largely due to the introduction of a form of lazy buddy merging mechanism > that avoids cache misses by postponing buddy merging until a high-order > allocation needs it. BTW. I would feel better about this if it gets merged in stages, with functional changes split out, and also code optimisations and omore obvious performace improvements split out and preferably merged first. At a very quick glance, the first 25 or so patches should go in first, and that gives a much better base to compare subsequent functional changes with. Patch 18 for example is really significant, and should almost be 2.6.29/-stable material IMO. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/