Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760656AbZCPRGl (ORCPT ); Mon, 16 Mar 2009 13:06:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760111AbZCPRF6 (ORCPT ); Mon, 16 Mar 2009 13:05:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36819 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760227AbZCPRF5 (ORCPT ); Mon, 16 Mar 2009 13:05:57 -0400 Date: Mon, 16 Mar 2009 18:05:51 +0100 From: Nick Piggin To: Mel Gorman Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Christoph Lameter , Johannes Weiner , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 00/35] Cleanup and optimise the page allocator V3 Message-ID: <20090316170551.GI30802@wotan.suse.de> References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> <20090316104054.GA23046@wotan.suse.de> <20090316111906.GA6382@csn.ul.ie> <20090316113358.GA30802@wotan.suse.de> <20090316120216.GB6382@csn.ul.ie> <20090316122505.GD30802@wotan.suse.de> <20090316133232.GA24293@csn.ul.ie> <20090316155342.GH30802@wotan.suse.de> <20090316165628.GP24293@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090316165628.GP24293@csn.ul.ie> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1297 Lines: 31 On Mon, Mar 16, 2009 at 04:56:28PM +0000, Mel Gorman wrote: > On Mon, Mar 16, 2009 at 04:53:42PM +0100, Nick Piggin wrote: > > So yes definitely I think there should be a very real impact on > > higher order coalescing no matter what you do. > > > > Because this is not straight-forward at all, I'll put lazy buddy onto > the back-burner and exhaust all other possibilities before revisiting it > again. If it is such a big improvement, I expect *most* people will want it and we probably should do it. But just that it will not play nicely with fragmentation and so you'd need to look into it and devise some way those users can tune it to be nicer. > > unmovable zone fragmentation is more important point because it > > eventually can destroy the movable zone. > > > > Which is why rmqueue_fallback() also merges up all buddies before making > any decisions but I accept your points. Right, that merge of buddies will only be able to look at what is currently free. Wheras non-lazy buddy can pull out higher orders before reallocating them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/