Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757461AbZCPRZn (ORCPT ); Mon, 16 Mar 2009 13:25:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755413AbZCPRZX (ORCPT ); Mon, 16 Mar 2009 13:25:23 -0400 Received: from mail2.shareable.org ([80.68.89.115]:58860 "EHLO mail2.shareable.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754921AbZCPRZW (ORCPT ); Mon, 16 Mar 2009 13:25:22 -0400 Date: Mon, 16 Mar 2009 17:25:17 +0000 From: Jamie Lokier To: Davide Libenzi Cc: Linux Kernel Mailing List , Benjamin LaHaise , Trond Myklebust , Andrew Morton , Eric Dumazet , linux-aio , zach.brown@oracle.com Subject: Re: [patch] eventfd - remove fput() call from possible IRQ context (2nd rev) Message-ID: <20090316172517.GC2453@shareable.org> References: <49B8A75E.6040409@cosmosbay.com> <20090311233903.f036027a.akpm@linux-foundation.org> <1236986902.7265.73.camel@heimdal.trondhjem.org> <1237003328.7265.98.camel@heimdal.trondhjem.org> <20090315174445.GD18305@kvack.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 455 Lines: 14 Davide Libenzi wrote: > + if (unlikely(req->ki_eventfd != NULL)) { Is this really unlikely? Having an eventfd seems to be the modern, cool, recommended way to do AIO. The other unlikelies look ok. -- Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/