Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761948AbZCPSBg (ORCPT ); Mon, 16 Mar 2009 14:01:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760408AbZCPRz1 (ORCPT ); Mon, 16 Mar 2009 13:55:27 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:43533 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761021AbZCPRzZ (ORCPT ); Mon, 16 Mar 2009 13:55:25 -0400 Date: Mon, 16 Mar 2009 12:30:02 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Mel Gorman cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 29/35] Do not store the PCP high and batch watermarks in the per-cpu structure In-Reply-To: <1237196790-7268-30-git-send-email-mel@csn.ul.ie> Message-ID: References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> <1237196790-7268-30-git-send-email-mel@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 35 On Mon, 16 Mar 2009, Mel Gorman wrote: > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -166,8 +166,6 @@ static inline int is_unevictable_lru(enum lru_list l) > > struct per_cpu_pages { > int count; /* number of pages in the list */ > - int high; /* high watermark, emptying needed */ > - int batch; /* chunk size for buddy add/remove */ There is a hole here on 64 bit systems. > > /* Lists of pages, one per migrate type stored on the pcp-lists */ > struct list_head lists[MIGRATE_PCPTYPES]; > @@ -285,6 +283,12 @@ struct zone { > unsigned long pages_mark[3]; > }; > > + /* high watermark for per-cpu lists, emptying needed */ > + u16 pcp_high; > + > + /* chunk size for buddy add/remove to per-cpu lists*/ > + u16 pcp_batch; > + Move this up to fill the hole? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/