Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761997AbZCPSBw (ORCPT ); Mon, 16 Mar 2009 14:01:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761094AbZCPRzk (ORCPT ); Mon, 16 Mar 2009 13:55:40 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:46088 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759521AbZCPRzj (ORCPT ); Mon, 16 Mar 2009 13:55:39 -0400 Date: Mon, 16 Mar 2009 12:47:35 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Mel Gorman cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 20/35] Use a pre-calculated value for num_online_nodes() In-Reply-To: <20090316163626.GJ24293@csn.ul.ie> Message-ID: References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> <1237196790-7268-21-git-send-email-mel@csn.ul.ie> <20090316163626.GJ24293@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 21 On Mon, 16 Mar 2009, Mel Gorman wrote: > On Mon, Mar 16, 2009 at 12:08:25PM -0400, Christoph Lameter wrote: > > On Mon, 16 Mar 2009, Mel Gorman wrote: > > > > > +extern int static_num_online_nodes; > > > > Strange name. Could we name this nr_online_nodes or so? > > > > It's to match the function name. Arguably I could also have replaced the > implementation of num_online_nodes() with a version that uses the static > variable. We have nr_node_ids etc. It would be consistant with that naming. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/