Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757764AbZCPShQ (ORCPT ); Mon, 16 Mar 2009 14:37:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753055AbZCPShB (ORCPT ); Mon, 16 Mar 2009 14:37:01 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:55694 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbZCPShA (ORCPT ); Mon, 16 Mar 2009 14:37:00 -0400 X-AuthUser: davidel@xmailserver.org Date: Mon, 16 Mar 2009 11:36:39 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@makko.or.mcafeemobile.com To: Jamie Lokier cc: Linux Kernel Mailing List , Benjamin LaHaise , Trond Myklebust , Andrew Morton , Eric Dumazet , linux-aio , zach.brown@oracle.com Subject: Re: [patch] eventfd - remove fput() call from possible IRQ context (2nd rev) In-Reply-To: <20090316172517.GC2453@shareable.org> Message-ID: References: <49B8A75E.6040409@cosmosbay.com> <20090311233903.f036027a.akpm@linux-foundation.org> <1236986902.7265.73.camel@heimdal.trondhjem.org> <1237003328.7265.98.camel@heimdal.trondhjem.org> <20090315174445.GD18305@kvack.org> <20090316172517.GC2453@shareable.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 672 Lines: 22 On Mon, 16 Mar 2009, Jamie Lokier wrote: > Davide Libenzi wrote: > > + if (unlikely(req->ki_eventfd != NULL)) { > > Is this really unlikely? Having an eventfd seems to be the modern, > cool, recommended way to do AIO. I don't have statistics at hand, but I guess that nowadays AIO+eventfd is still not very popular. It doesn't make much of a difference either ways I guess, so we could drop the unlikely(). - Davide -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/