Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758833AbZCPSzB (ORCPT ); Mon, 16 Mar 2009 14:55:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753830AbZCPSyt (ORCPT ); Mon, 16 Mar 2009 14:54:49 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:52246 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbZCPSys (ORCPT ); Mon, 16 Mar 2009 14:54:48 -0400 Date: Mon, 16 Mar 2009 12:26:07 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Mel Gorman cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 26/35] Use the per-cpu allocator for orders up to PAGE_ALLOC_COSTLY_ORDER In-Reply-To: <1237196790-7268-27-git-send-email-mel@csn.ul.ie> Message-ID: References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> <1237196790-7268-27-git-send-email-mel@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 46 On Mon, 16 Mar 2009, Mel Gorman wrote: > -static void free_hot_cold_page(struct page *page, int cold) > +static void free_hot_cold_page(struct page *page, int order, int cold) > { > struct zone *zone = page_zone(page); > struct per_cpu_pages *pcp; > unsigned long flags; > int clearMlocked = PageMlocked(page); > > + /* SLUB can return lowish-order compound pages that need handling */ > + if (order > 0 && unlikely(PageCompound(page))) > + if (unlikely(destroy_compound_page(page, order))) > + return; > + Isnt that also true for stacks and generic network objects ==- 8k? > again: > cpu = get_cpu(); > - if (likely(order == 0)) { > + if (likely(order <= PAGE_ALLOC_COSTLY_ORDER)) { > struct per_cpu_pages *pcp; > + int batch; > + int delta; > > pcp = &zone_pcp(zone, cpu)->pcp; > + batch = max(1, pcp->batch >> order); > local_irq_save(flags); > if (!pcp->count) { > - pcp->count = rmqueue_bulk(zone, 0, > - pcp->batch, &pcp->list, migratetype); > + delta = rmqueue_bulk(zone, order, batch, > + &pcp->list, migratetype); > + bulk_add_pcp_page(pcp, order, delta); > if (unlikely(!pcp->count)) > goto failed; The pcp adds a series of order N pages if an order N alloc occurs and the queue is empty? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/