Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755704AbZCPTKP (ORCPT ); Mon, 16 Mar 2009 15:10:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753457AbZCPTKB (ORCPT ); Mon, 16 Mar 2009 15:10:01 -0400 Received: from buzzloop.caiaq.de ([212.112.241.133]:51109 "EHLO buzzloop.caiaq.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753904AbZCPTKA (ORCPT ); Mon, 16 Mar 2009 15:10:00 -0400 Date: Mon, 16 Mar 2009 20:09:54 +0100 From: Daniel Mack To: =?iso-8859-1?Q?=C9ric?= Piel Cc: linux-kernel@vger.kernel.org, Pavel Machek Subject: Re: [PATCH 4/5] lis3: solve dependency between core and ACPI Message-ID: <20090316190954.GK16052@buzzloop.caiaq.de> References: <49ABB22F.7040508@tremplin-utc.net> <1236004310-29196-1-git-send-email-daniel@caiaq.de> <1236004310-29196-2-git-send-email-daniel@caiaq.de> <1236004310-29196-3-git-send-email-daniel@caiaq.de> <1236004310-29196-4-git-send-email-daniel@caiaq.de> <49AD8B0A.90901@tremplin-utc.net> <20090304014350.GC5165@buzzloop.caiaq.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090304014350.GC5165@buzzloop.caiaq.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 31 Hi, On Wed, Mar 04, 2009 at 02:43:50AM +0100, Daniel Mack wrote: > On Tue, Mar 03, 2009 at 08:54:50PM +0100, ?ric Piel wrote: > > Daniel Mack schreef: > > > This solves the dependency between lis3lv02d.[ch] and ACPI specific > > > methods. It introduces a ->bus_priv pointer to the device struct which > > > is casted to 'struct acpi_device' in the ACIP layer. Changed hp_accel.c > > > accordingly. > > > > > > This also moves the read_8() and read_16() routines from hp_accel.c to > > > lis3lv02d.c as they are not specific to ACPI. > > Hello, > > I've tried the patch series on my laptop. This particular patch burst > > the driver... need some work :-) The values are not read correctly and > > the IRQ is not detected. See down in the code... > > Ok, obvious fixes. I'll post a new set of the three topmost patches - > could you test them again, please? Could anyone test that on hardware which has a lis3 chip? I'd like to avoid missing the next merge window for this :) Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/