DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=y3KQoDmYrIJVJ2cMR4aZ6HWmB+pVC+ig613nWqbYakix9HbQIsSH5eSt4O34BcKe8+jJuM01Qbg0Eg5aJStIMKl/izN6UvrwZSkFtj+PidmCEqJM3sYJjKG3M2GX1WIkA0K4vdihoIdjh4ketMUG6T2Za+TGt8q6S7+aAIoTgg8=  ;
From: David Brownell <david-b@pacbell.net>
To: Purushotam Kumar <purushotam@ti.com>
Subject: Re: [PATCH 1/1] DaVinci: MMC: MMC/SD controller driver for DaVinci/DM6446.
Date: Mon, 16 Mar 2009 14:08:45 -0700
User-Agent: KMail/1.9.10
Cc: davinci-linux-open-source@linux.davincidsp.com,
       linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
References: <1237214559-31345-1-git-send-email-purushotam@ti.com>
In-Reply-To: <1237214559-31345-1-git-send-email-purushotam@ti.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200903161408.45897.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 777
Lines: 27

I noticed a newish bug in probe() ...

On Monday 16 March 2009, Purushotam Kumar wrote:
> +???????if (!pdata || pdata->wires == 4 || pdata->wires == 0)
> +???????????????mmc->caps |= MMC_CAP_4_BIT_DATA;

So pdata may be null.  But, if it is, then ...

> +
> +???????mmc->ops = &mmc_davinci_ops;
> +???????mmc->f_min = 312500;
> +???????mmc->f_max = 25000000;
> +???????if (pdata->max_freq)
> +???????????????mmc->f_max = pdata->max_freq;

Oops!

> +???????if (pdata->caps)
> +???????????????mmc->caps |= pdata->caps;

Double oops!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/