Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761993AbZCPV7o (ORCPT ); Mon, 16 Mar 2009 17:59:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758705AbZCPV7f (ORCPT ); Mon, 16 Mar 2009 17:59:35 -0400 Received: from wa-out-1112.google.com ([209.85.146.182]:48450 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756746AbZCPV7e (ORCPT ); Mon, 16 Mar 2009 17:59:34 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=WiOMINqBotopzc79iFWW+8G98GT95a88VmYbZ6Qrk94ADMPOY+Jrl1wHsu9rvhSJGh 3vWNmn+D1aLhRnFP7/zUazcBM7cWJJHjXw3Mnr3LhQiMb1GUulBh5zOKG9gi+0u7MUxo ZQHZDxfwIK3JMDPnuiOq9DygcXDT01WFPNPu4= MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 16 Mar 2009 14:59:33 -0700 X-Google-Sender-Auth: 665c9ce65be99ab3 Message-ID: Subject: Re: [PATCH] ipu_idmac: code clean-up and robustness improvements From: Dan Williams To: Guennadi Liakhovetski Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 24 On Fri, Mar 13, 2009 at 12:41 AM, Guennadi Liakhovetski wrote: > General code clean-up: remove superfluous semicolons, update comments. > Robustness improvements: add DMA error handling to the ISR, move common code > fragments to functions, fix scatter-gather element queuing in the ISR, survive > channel freeing and re-allocation in a quick succession. > > Signed-off-by: Guennadi Liakhovetski > --- > > Dan, I've been using this patch for a while, without any need for a > change, so, it should be fine to go upstream. > Are you sure that we will never want to bisect in between these several topics? I would feel more comfortable with at least the fixes separated from the code refactoring/pure additions. Thanks, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/