Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758436AbZCQTJg (ORCPT ); Tue, 17 Mar 2009 15:09:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752189AbZCQTJ1 (ORCPT ); Tue, 17 Mar 2009 15:09:27 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:57274 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbZCQTJ0 (ORCPT ); Tue, 17 Mar 2009 15:09:26 -0400 Date: Tue, 17 Mar 2009 15:09:05 -0400 From: Christoph Hellwig To: Nikanth Karthikesan Cc: Jens Axboe , Christoph Hellwig , Gerd Hoffmann , Constantine Sapuntzakis , Miklos Szeredi , nikanth@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Block - Honour barrier requests in loop driver Message-ID: <20090317190905.GA28816@infradead.org> References: <200903171417.16760.knikanth@suse.de> <20090317091926.GA26016@infradead.org> <200903171739.50658.knikanth@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200903171739.50658.knikanth@suse.de> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 501 Lines: 14 On Tue, Mar 17, 2009 at 05:39:49PM +0530, Nikanth Karthikesan wrote: > + if (!file->f_op || !file->f_op->fsync) { > + ret = -EOPNOTSUPP; > + goto out; > + } file->f_op is never zero, so you can remove the checks for that. Otherwise looks good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/