Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755123AbZCRPIu (ORCPT ); Wed, 18 Mar 2009 11:08:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757330AbZCRPIh (ORCPT ); Wed, 18 Mar 2009 11:08:37 -0400 Received: from gir.skynet.ie ([193.1.99.77]:47141 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757261AbZCRPIg (ORCPT ); Wed, 18 Mar 2009 11:08:36 -0400 Date: Wed, 18 Mar 2009 15:08:33 +0000 From: Mel Gorman To: Christoph Lameter Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 20/35] Use a pre-calculated value for num_online_nodes() Message-ID: <20090318150833.GC4629@csn.ul.ie> References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> <1237196790-7268-21-git-send-email-mel@csn.ul.ie> <20090316163626.GJ24293@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 31 On Mon, Mar 16, 2009 at 12:47:35PM -0400, Christoph Lameter wrote: > On Mon, 16 Mar 2009, Mel Gorman wrote: > > > On Mon, Mar 16, 2009 at 12:08:25PM -0400, Christoph Lameter wrote: > > > On Mon, 16 Mar 2009, Mel Gorman wrote: > > > > > > > +extern int static_num_online_nodes; > > > > > > Strange name. Could we name this nr_online_nodes or so? > > > > > > > It's to match the function name. Arguably I could also have replaced the > > implementation of num_online_nodes() with a version that uses the static > > variable. > > We have nr_node_ids etc. It would be consistant with that naming. > Naming has never been great, but in this case the static value is a direct replacement of num_online_nodes(). I think having a similarly-named-but-still-different name obscures more than it helps. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/