Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758814AbZCRRE1 (ORCPT ); Wed, 18 Mar 2009 13:04:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757120AbZCRRER (ORCPT ); Wed, 18 Mar 2009 13:04:17 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:44649 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbZCRRER (ORCPT ); Wed, 18 Mar 2009 13:04:17 -0400 Date: Wed, 18 Mar 2009 12:58:02 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Mel Gorman cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 20/35] Use a pre-calculated value for num_online_nodes() In-Reply-To: <20090318150833.GC4629@csn.ul.ie> Message-ID: References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> <1237196790-7268-21-git-send-email-mel@csn.ul.ie> <20090316163626.GJ24293@csn.ul.ie> <20090318150833.GC4629@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 15 On Wed, 18 Mar 2009, Mel Gorman wrote: > Naming has never been great, but in this case the static value is a > direct replacement of num_online_nodes(). I think having a > similarly-named-but-still-different name obscures more than it helps. Creates a weird new name. Please use nr_online_nodes. Its useful elsewhere too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/