Subject: Re: [PATCH] BTRFS: Transpose parent_objectid and parent_gen in
 struct btrfs_fid
From: David Woodhouse <dwmw2@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Chris Mason <chris.mason@oracle.com>, balajirrao@gmail.com,
       linux-kernel@vger.kernel.org
In-Reply-To: <21667.1237395905@redhat.com>
References: <1237395629.10384.2.camel@think.oraclecorp.com>
	 <20090318161626.16521.91662.stgit@warthog.procyon.org.uk>
	 <21667.1237395905@redhat.com>
Content-Type: text/plain
Date: Wed, 18 Mar 2009 17:21:49 +0000
Message-Id: <1237396909.27829.102.camel@macbook.infradead.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1001
Lines: 25

On Wed, 2009-03-18 at 17:05 +0000, David Howells wrote:
> Chris Mason <chris.mason@oracle.com> wrote:
> 
> > Won't this confuse any handles the clients already have if the server
> > reboots with the new handle format?
> 
> Perhaps, but it's probably early enough in BTRFS's life to get away with it.

True. It's not that hard to handle compatibility if we really care,
either.

But this struct is packed anyway -- we're not changing much on the wire;
it's just a case of how efficient it is to load that single uint64_t
from an unaligned location. Is that _really_ something we're ever going
to notice?

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/