Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755033AbZCRRYj (ORCPT ); Wed, 18 Mar 2009 13:24:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752423AbZCRRYa (ORCPT ); Wed, 18 Mar 2009 13:24:30 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:57731 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbZCRRY3 (ORCPT ); Wed, 18 Mar 2009 13:24:29 -0400 Date: Wed, 18 Mar 2009 13:21:30 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Mel Gorman cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 24/27] Convert gfp_zone() to use a table of precalculated values In-Reply-To: <20090318153508.GA24462@csn.ul.ie> Message-ID: References: <1237226020-14057-1-git-send-email-mel@csn.ul.ie> <1237226020-14057-25-git-send-email-mel@csn.ul.ie> <20090318135222.GA4629@csn.ul.ie> <20090318153508.GA24462@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3768 Lines: 105 > time. > > > > > const int gfp_zone_table[GFP_ZONEMASK] = { > > > > ZONE_NORMAL, /* 00 No flags set */ > > > > ZONE_DMA, /* 01 Only GFP_DMA set */ > > > > ZONE_HIGHMEM, /* 02 Only GFP_HIGHMEM set */ > > > > ZONE_DMA, /* 03 GFP_HIGHMEM and GFP_DMA set */ > > > > ZONE_DMA32, /* 04 Only GFP_DMA32 set */ > > > > ZONE_DMA, /* 05 GFP_DMA and GFP_DMA32 set */ > > > > ZONE_DMA32, /* 06 GFP_DMA32 and GFP_HIGHMEM set */ > > > > ZONE_DMA, /* 07 GFP_DMA, GFP_DMA32 and GFP_DMA32 set */ > > > > ZONE_MOVABLE, /* 08 Only ZONE_MOVABLE set */ > > > > ZONE_DMA, /* 09 MOVABLE + DMA */ > > > > ZONE_MOVABLE, /* 0A MOVABLE + HIGHMEM */ > > > > ZONE_DMA, /* 0B MOVABLE + DMA + HIGHMEM */ > > > > ZONE_DMA32, /* 0C MOVABLE + DMA32 */ > > > > ZONE_DMA, /* 0D MOVABLE + DMA + DMA32 */ > > > > ZONE_DMA32, /* 0E MOVABLE + DMA32 + HIGHMEM */ > > > > ZONE_DMA /* 0F MOVABLE + DMA32 + HIGHMEM + DMA > > > > }; > > > > > > > > Hmmmm... Guess one would need to add some #ifdeffery here to setup > > > > ZONE_NORMAL in cases there is no DMA, DMA32 and HIGHMEM. > > > > > > > > > > Indeed, as I said, this is somewhat error prone which is why the patch > > > calculates the table at run-time instead of compile-time trickery. > > > > One would need to define some macros to make it simpler I guess > > > > Write something like > > > > #ifdef CONFIG_ZONE_DMA > > #define TZONE_DMA ZONE_DMA > > #else > > #define TZONE_DMA ZONE_NORMAL > > #endif > > > > for each configurable item. Then just add the T to the above table. > > > > If you don't mind, I'd like to postpone writing such a patch until a second > or third pass at improving the allocator. I don't think I'll have the time > in the short-term to put together a const-initialised-table patch that will > definitily be correct. > > Alternatively, I can drop this patch entirely from the set. > > Let me give it a shot: Note that there is a slight buggyness in the current implementation of gfp_zone. If you set both GFP_DMA32 and GFP_HIGHMEM and the arch does not support GFP_DMA32 then gfp_zone returns GFP_HIGHMEM which may result in memory being allocated that cannot be used for I/O. This version here returns GFP_NORMAL which is more correct. #ifdef CONFIG_ZONE_HIGHMEM #define OPT_ZONE_HIGHMEM ZONE_HIGHMEM #else #define OPT_ZONE_HIGHMEM ZONE_NORMAL #endif #ifdef CONFIG_ZONE_DMA #define OPT_ZONE_DMA ZONE_DMA #else #define OPT_ZONE_DMA ZONE_NORMAL #endif #ifdef CONFIG_ZONE_DMA32 #define OPT_ZONE_DMA32 ZONE_DMA32 #else #define OPT_ZONE_DMA32 OPT_ZONE_DMA #endif const int gfp_zone_table[GFP_ZONEMASK] = { ZONE_NORMAL, /* 00 No flags set */ OPT_ZONE_DMA, /* 01 GFP_DMA */ OPT_ZONE_HIGHMEM, /* 02 GFP_HIGHMEM */ OPT_ZONE_DMA, /* 03 GFP_HIGHMEM GFP_DMA */ OPT_ZONE_DMA32, /* 04 GFP_DMA32 */ OPT_ZONE_DMA, /* 05 GFP_DMA32 GFP_DMA */ OPT_ZONE_DMA32, /* 06 GFP_DMA32 GFP_HIGHMEM */ OPT_ZONE_DMA, /* 07 GFP_DMA32 GFP_HIGHMEM GFP_DMA */ ZONE_NORMAL, /* 08 ZONE_MOVABLE */ OPT_ZONE_DMA, /* 09 MOVABLE + DMA */ ZONE_MOVABLE, /* 0A MOVABLE + HIGHMEM */ OPT_ZONE_DMA, /* 0B MOVABLE + HIGHMEM + DMA */ OPT_ZONE_DMA32, /* 0C MOVABLE + DMA32 */ OPT_ZONE_DMA, /* 0D MOVABLE + DMA32 + DMA */ OPT_ZONE_DMA32, /* 0E MOVABLE + DMA32 + HIGHMEM */ OPT_ZONE_DMA /* 0F MOVABLE + DMA32 + HIGHMEM + DMA */ }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/