Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757004AbZCSCaa (ORCPT ); Wed, 18 Mar 2009 22:30:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753709AbZCSCaV (ORCPT ); Wed, 18 Mar 2009 22:30:21 -0400 Received: from rv-out-0506.google.com ([209.85.198.226]:32561 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbZCSCaU (ORCPT ); Wed, 18 Mar 2009 22:30:20 -0400 MIME-Version: 1.0 In-Reply-To: <84144f020903181221t480caa5dhef0e581a7bef006@mail.gmail.com> References: <49BF8ABC.6040805@vflare.org> <49BF8B8B.40408@vflare.org> <49C11088.7000205@vflare.org> <84144f020903181221t480caa5dhef0e581a7bef006@mail.gmail.com> Date: Thu, 19 Mar 2009 08:00:17 +0530 Message-ID: Subject: Re: [PATCH 2/3]: xvmalloc memory allocator From: Nitin Gupta To: Pekka Enberg Cc: Christoph Lameter , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 31 On Thu, Mar 19, 2009 at 12:51 AM, Pekka Enberg wrote: > On Wed, 18 Mar 2009, Nitin Gupta wrote: >>>> > Slab memory is not backed by vmalloc space. >>>> Oh, it uses "low memory". Still not good for compcache :) > > On Wed, Mar 18, 2009 at 10:28 PM, Christoph Lameter > wrote: >>> Only if you use 32 bit. > > On Wed, Mar 18, 2009 at 10:29 AM, Nitin Gupta wrote: >> Yes, this point is for 32-bit only - many users were unhappy with >> compcache size limit due to small vmalloc area on x86-32. > > Yeah, I can see the point in having a custom allocator for this. But > quite frankly the xvmalloc code is just too ugly to live with. You > might want to make it look like kernel code as per CodingStyle and > change the name to something less generic. > I can see quite some places for cleanups (like macros for reaching next free block etc). Do you think CamelCase will be acceptable for now? and also keeping xvmalloc name? Other than these, I will check for potential cleanups and send updated diffs. Thanks, Nitin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/