Date: Thu, 19 Mar 2009 02:29:56 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Alex Chiang <achiang@hp.com>
Cc: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/12] PCI: Introduce pci_rescan_bus()
Message-Id: <20090319022956.25ae6a5a.akpm@linux-foundation.org>
In-Reply-To: <20090318223956.887.57080.stgit@bob.kio>
References: <20090318222426.887.1008.stgit@bob.kio>
	<20090318223956.887.57080.stgit@bob.kio>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1181
Lines: 41

On Wed, 18 Mar 2009 16:39:56 -0600 Alex Chiang <achiang@hp.com> wrote:

> +/**
> + * pci_rescan_bus - scan a PCI bus for devices.
> + * @bus: PCI bus to scan
> + *
> + * Scan a PCI bus and child buses for new devices, adds them,
> + * and enables them.
> + *
> + * Returns the max number of subordinate bus discovered.
> + */
> +unsigned int __devinit pci_rescan_bus(struct pci_bus *bus)
> +{
> +	unsigned int max;
> +	struct pci_dev *dev;
> +
> +	max = pci_scan_child_bus(bus);
> +	list_for_each_entry(dev, &bus->devices, bus_list)
> +		if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
> +		    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)
> +			if (dev->subordinate)
> +				pci_bus_size_bridges(dev->subordinate);
> +
> +	pci_bus_assign_resources(bus);
> +	pci_enable_bridges(bus);
> +	pci_bus_add_devices(bus);
> +
> +	return max;
> +}

The conspicuous lack of locking for the list walk requires either

a) documenting or
b) fixing

IMO.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/