Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755345AbZCSLBW (ORCPT ); Thu, 19 Mar 2009 07:01:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752777AbZCSLBN (ORCPT ); Thu, 19 Mar 2009 07:01:13 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:53169 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbZCSLBM (ORCPT ); Thu, 19 Mar 2009 07:01:12 -0400 Date: Thu, 19 Mar 2009 12:00:56 +0100 From: Ingo Molnar To: Michal Simek Cc: linux-kernel@vger.kernel.org, john.williams@petalogix.com, Andrew Morton Subject: Re: Microblaze linux support Message-ID: <20090319110056.GA11077@elte.hu> References: <1237408284-8674-1-git-send-email-monstr@monstr.eu> <20090319072256.GA5069@elte.hu> <49C213A2.4040609@monstr.eu> <20090319102142.GA2579@elte.hu> <49C21DF0.10808@monstr.eu> <20090319105001.GC2579@elte.hu> <49C22401.60007@monstr.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49C22401.60007@monstr.eu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 52 * Michal Simek wrote: > Ingo Molnar wrote: > > * Michal Simek wrote: > > > >> Hi Ingo, > >>> * Michal Simek wrote: > >>> > >>>> WARNING: externs should be avoided in .c files > >>>> #110: FILE: arch/microblaze/kernel/microblaze_ksyms.c:45: > >>>> +extern void __umodsi3(void); > >>>> > >>>> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > >>>> #111: FILE: arch/microblaze/kernel/microblaze_ksyms.c:46: > >>>> +EXPORT_SYMBOL(__umodsi3); > >>> externs should be in header files. > >>> > >>> The rest indeed looks like false positives. Thanks for addressing > >>> these things so quickly! > >> you are welcome - I can quickly test and add all changes to git. > >> > >> Is it good style separate extern definition and EXPORT_SYMBOL? > >> > >> I have three choices? > >> 1. keep extern + EXPORT_SYMBOL below - current style > >> 2. move only extern to header file > >> 3. move extern and EXPORT_SYMBOL to header. > >> > >> What is preferable way? > > > > Where are the symbols defined - by gcc's library? > > yes. i suspect it's borderline in that case, and your solution is fine. The other solution would be to stuff the externs into a header and have a continuous block of exports with a comment that says: /* * GCC library functions: */ EXPORT_SYMBOL(...); EXPORT_SYMBOL(...); EXPORT_SYMBOL(...); Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/