Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758651AbZCSQ6x (ORCPT ); Thu, 19 Mar 2009 12:58:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753694AbZCSQ6n (ORCPT ); Thu, 19 Mar 2009 12:58:43 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41098 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752668AbZCSQ6m (ORCPT ); Thu, 19 Mar 2009 12:58:42 -0400 Date: Thu, 19 Mar 2009 09:51:59 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Nick Piggin cc: Ying Han , Jan Kara , Andrew Morton , linux-kernel , linux-mm , guichaz@gmail.com, Alex Khesin , Mike Waychison , Rohit Seth , Peter Zijlstra Subject: Re: ftruncate-mmap: pages are lost after writing to mmaped file. In-Reply-To: <200903200334.55710.nickpiggin@yahoo.com.au> Message-ID: References: <604427e00903181244w360c5519k9179d5c3e5cd6ab3@mail.gmail.com> <200903200248.22623.nickpiggin@yahoo.com.au> <200903200334.55710.nickpiggin@yahoo.com.au> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1005 Lines: 25 On Fri, 20 Mar 2009, Nick Piggin wrote: > > Yeah, probably no need to hold private_lock while tagging the radix > tree (which is what my version did). So maybe this one is a little > better. I did test mine, it worked, but it didn't solve the problem. Ahh, so you re-created it? On ext2 only, or is it visible on ext3 as well? I've not even tested - I assumed that I would have to boot into less memory and downgrade my filesystem to ext2, which made me hope somebody else would pick it up first ;) > Still, it does appear to solve a real race, which we should close. A very small and unlikely race, but yeah - the patch isn't large, removes more lines than it adds, and the code seems to make _more_ sense with it in place than without. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/