Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759636AbZCSRIB (ORCPT ); Thu, 19 Mar 2009 13:08:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753523AbZCSRHv (ORCPT ); Thu, 19 Mar 2009 13:07:51 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:21917 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbZCSRHu (ORCPT ); Thu, 19 Mar 2009 13:07:50 -0400 Date: Thu, 19 Mar 2009 11:07:47 -0600 From: Alex Chiang To: Kenji Kaneshige Cc: jbarnes@virtuousgeek.org, shimada-yxb@necst.nec.co.jp, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/12] PCI core learns hotplug Message-ID: <20090319170747.GF8074@ldl.fc.hp.com> References: <20090318222426.887.1008.stgit@bob.kio> <49C1FE8A.9000401@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49C1FE8A.9000401@jp.fujitsu.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7251 Lines: 169 * Kenji Kaneshige : > Alex Chiang wrote: >> We're getting close to the new merge window, and I _think_ this >> patch series is ready for consideration. Notably: >> >> - multiple rescans/removes of devices with and without bridges >> - verified that resource allocation after multiple remove/rescan >> cycles is the same as what we had during initial boot >> - fixes the complete suckage of fakephp (that I created) >> - doesn't affect existing hotplug drivers >> - tested on x86 and ia64 platforms >> >> Please review, and consider testing. For testing ease, you can pull >> from my git branch: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/achiang/pci-hotplug.git >> branch 'test-20090318' is what you want >> > > I got the following oops when I did > > # echo 1 > remove > > on the bridge device. Hm, this is odd; I did test under lockdep. I'll try again, thanks for testing and the bug report. /ac > > [ 6639.239164] ============================================= > [ 6639.239191] [ INFO: possible recursive locking detected ] > [ 6639.239212] 2.6.29-rc8-kk #1 > [ 6639.239227] --------------------------------------------- > [ 6639.239243] events/8/60 is trying to acquire lock: > [ 6639.239252] (events){--..}, at: [] flush_workqueue+0x0/0xa0 > [ 6639.239252] > [ 6639.239252] but task is already holding lock: > [ 6639.239252] (events){--..}, at: [] run_workqueue+0x108/0x230 > [ 6639.239252] > [ 6639.239252] other info that might help us debug this: > [ 6639.239252] 3 locks held by events/8/60: > [ 6639.239252] #0: (events){--..}, at: [] run_workqueue+0x108/0x230 > [ 6639.239252] #1: (&ss->work){--..}, at: [] run_workqueue+0x108/0x230 > [ 6639.239252] #2: (pci_remove_rescan_mutex){--..}, at: [] remove_callback+0x29/0x80 > [ 6639.239252] > [ 6639.239252] stack backtrace: > [ 6639.239252] Pid: 60, comm: events/8 Not tainted 2.6.29-rc8-kk #1 > [ 6639.239252] Call Trace: > [ 6639.239252] [] validate_chain+0xb7d/0x1260 > [ 6639.239252] [] __lock_acquire+0x42e/0xa40 > [ 6639.239252] [] lock_acquire+0x58/0x80 > [ 6639.239252] [] ? flush_workqueue+0x0/0xa0 > [ 6639.239252] [] flush_workqueue+0x4d/0xa0 > [ 6639.239252] [] ? flush_workqueue+0x0/0xa0 > [ 6639.239252] [] flush_scheduled_work+0x10/0x20 > [ 6639.239252] [] e1000_remove+0x55/0xfe [e1000e] > [ 6639.239252] [] ? sysfs_schedule_callback_work+0x0/0x50 > [ 6639.239252] [] pci_device_remove+0x32/0x70 > [ 6639.239252] [] __device_release_driver+0x59/0x90 > [ 6639.241006] [] device_release_driver+0x2b/0x40 > [ 6639.241006] [] bus_remove_device+0xa6/0x120 > [ 6639.241006] [] device_del+0x12b/0x190 > [ 6639.241006] [] device_unregister+0x26/0x70 > [ 6639.241006] [] pci_stop_dev+0x49/0x60 > [ 6639.241006] [] pci_remove_bus_device+0x40/0xc0 > [ 6639.241006] [] pci_remove_behind_bridge+0x2d/0x50 > [ 6639.241006] [] pci_remove_bus_device+0x1e/0xc0 > [ 6639.241006] [] remove_callback+0x38/0x80 > [ 6639.241006] [] sysfs_schedule_callback_work+0x1f/0x50 > [ 6639.241006] [] run_workqueue+0x15a/0x230 > [ 6639.241006] [] ? run_workqueue+0x108/0x230 > [ 6639.241006] [] worker_thread+0x9f/0x100 > [ 6639.241006] [] ? autoremove_wake_function+0x0/0x40 > [ 6639.241006] [] ? worker_thread+0x0/0x100 > [ 6639.241006] [] kthread+0x4d/0x80 > [ 6639.241006] [] child_rip+0xa/0x20 > [ 6639.241006] [] ? restore_args+0x0/0x30 > [ 6639.241006] [] ? kthread+0x0/0x80 > [ 6639.241006] [] ? child_rip+0x0/0x20 > [ 6639.283330] e1000e 0000:40:00.0: PCI INT A disabled > [ 6639.324332] e1000e 0000:40:00.1: PCI INT B disabled > [ 6639.325031] aer 0000:2f:04.0:pcie22: unloading service driver aer > > Thanks, > Kenji Kaneshige > > >> Note, this test branch does contain the small assorted patches in AER >> and the PCIe portdriver that I fixed along the way, but does not contain >> the sysfs callback mutex that I introduced to protect myself from >> Vegard Nossum. ;) If you want to hammer away at the sysfs interface, >> please apply this patch on top: >> >> http://thread.gmane.org/gmane.linux.kernel/806648 >> >> What I'm continuing to do: >> >> - investigate converting existing hotplug drivers to use >> new pci_rescan_bus() interface >> >> Thanks. >> >> /ac >> >> v3 -> v4: >> - protect sysfs interfaces with mutex >> - undo changes in pci_do_scan_bus >> - introduce pci_rescan_bus instead >> - do not initialize bridges more than once >> >> v2 -> v3: >> - properly remove device with internal bridge >> - added Kenji Kaneshige's pci_is_root_bus() interface >> - dropped whitespace cleanups for another time >> >> v1 -> v2: >> - incorporated lots of Trent Piepho's work >> - beefed up pci_do_scan_bus as heavy lifter for rescanning >> - small bugfixes folded into earlier patches to get everything working >> >> --- >> >> Alex Chiang (8): >> PCI Hotplug: schedule fakephp for feature removal >> PCI Hotplug: rename legacy_fakephp to fakephp >> PCI: Introduce /sys/bus/pci/devices/.../rescan >> PCI: Introduce /sys/bus/pci/devices/.../remove >> PCI: Introduce /sys/bus/pci/rescan >> PCI: Introduce pci_rescan_bus() >> PCI: do not initialize bridges more than once >> PCI: always scan child buses >> >> Kenji Kaneshige (1): >> PCI: pci_is_root_bus helper >> >> Trent Piepho (3): >> PCI Hotplug: restore fakephp interface with complete reimplementation >> PCI: pci_scan_slot() returns newly found devices >> PCI: don't scan existing devices >> >> >> Documentation/ABI/testing/sysfs-bus-pci | 27 ++ >> Documentation/feature-removal-schedule.txt | 32 ++ >> Documentation/filesystems/sysfs-pci.txt | 10 + >> drivers/pci/hotplug/fakephp.c | 443 +++++++--------------------- >> drivers/pci/pci-driver.c | 1 >> drivers/pci/pci-sysfs.c | 95 ++++++ >> drivers/pci/pci.h | 6 drivers/pci/probe.c >> | 103 ++++--- >> drivers/pci/setup-bus.c | 3 include/linux/pci.h >> | 12 + >> 10 files changed, 358 insertions(+), 374 deletions(-) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pci" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/