Date: Thu, 19 Mar 2009 15:55:10 -0700 (PDT)
From: Trent Piepho <xyzzy@speakeasy.org>
To: Alex Chiang <achiang@hp.com>
cc: Andrew Morton <akpm@linux-foundation.org>, jbarnes@virtuousgeek.org,
       linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 07/12] PCI: Introduce /sys/bus/pci/rescan
In-Reply-To: <20090319171107.GG8074@ldl.fc.hp.com>
Message-ID: <Pine.LNX.4.58.0903191547130.28292@shell2.speakeasy.net>
References: <20090318222426.887.1008.stgit@bob.kio> <20090318224001.887.63554.stgit@bob.kio>
 <20090319023453.7467644a.akpm@linux-foundation.org> <20090319171107.GG8074@ldl.fc.hp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1527
Lines: 35

On Thu, 19 Mar 2009, Alex Chiang wrote:
> * Andrew Morton <akpm@linux-foundation.org>:
> > > +
> > > +struct bus_attribute pci_bus_attrs[] = {
> > > +	__ATTR(rescan, S_IWUSR, NULL, bus_rescan_store),
> > > +	__ATTR_NULL
> > > +};
> > > +#endif
> >
> > Why CONFIG_HOTPLUG rather than CONFIG_HOTPLUG_PCI (or similar)?
>
> I first started out with CONFIG_HOTPLUG_PCI but then all that
> stuff got compiled out, and I couldn't figure out why at the
> time.

HOTPLUG_PCI is a subset of HOTPLUG.  It gives you support for actual
hotplug hardware.  The rescan/remove functions don't do anything to hotplug
hardware and don't use any code from the pci hotplug core (which is
designed to support hotplug hardware).  Rescan and remove just need the
ability to unbind a driver from device, delete a device and create a new
device.  Which HOTPLUG gives us.

So, we use HOTPLUG because that's all we need.  The idea is to make the
sysfs interface for PCI have the most features it can support.

If we wanted to make the interface not have remove/rescan unless needed,
then using HOTPLUG_PCI wouldn't make much sense.  It would be better to
have a new option "PCI remove/rescan sysfs interface" or something that
turned it on.  But it isn't much code, so I don't think it's necessary to
do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/