Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761195AbZCTKJz (ORCPT ); Fri, 20 Mar 2009 06:09:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754178AbZCTKCv (ORCPT ); Fri, 20 Mar 2009 06:02:51 -0400 Received: from gir.skynet.ie ([193.1.99.77]:55070 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758109AbZCTKCq (ORCPT ); Fri, 20 Mar 2009 06:02:46 -0400 From: Mel Gorman To: Mel Gorman , Linux Memory Management List Cc: KOSAKI Motohiro , Christoph Lameter , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra , Andrew Morton Subject: [PATCH 19/25] Do not setup zonelist cache when there is only one node Date: Fri, 20 Mar 2009 10:03:06 +0000 Message-Id: <1237543392-11797-20-git-send-email-mel@csn.ul.ie> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1237543392-11797-1-git-send-email-mel@csn.ul.ie> References: <1237543392-11797-1-git-send-email-mel@csn.ul.ie> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 48 There is a zonelist cache which is used to track zones that are not in the allowed cpuset or found to be recently full. This is to reduce cache footprint on large machines. On smaller machines, it just incurs cost for no gain. This patch only uses the zonelist cache when there are NUMA nodes. Signed-off-by: Mel Gorman Reviewed-by: Christoph Lameter --- mm/page_alloc.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c4eb295..01cd489 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1442,6 +1442,8 @@ get_page_from_freelist(gfp_t gfp_mask, nodemask_t *nodemask, unsigned int order, /* Determine in advance if the zonelist needs filtering */ if ((alloc_flags & ALLOC_CPUSET) && unlikely(number_of_cpusets > 1)) zonelist_filter = 1; + if (num_online_nodes() > 1) + zonelist_filter = 1; zonelist_scan: /* @@ -1486,8 +1488,12 @@ this_zone_full: zlc_mark_zone_full(zonelist, z); try_next_zone: if (NUMA_BUILD && zonelist_filter) { - if (!did_zlc_setup) { - /* do zlc_setup after the first zone is tried */ + if (!did_zlc_setup && num_online_nodes() > 1) { + /* + * do zlc_setup after the first zone is tried + * but only if there are multiple nodes to make + * it worthwhile + */ allowednodes = zlc_setup(zonelist, alloc_flags); zlc_active = 1; } -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/