Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760990AbZCTKN5 (ORCPT ); Fri, 20 Mar 2009 06:13:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760366AbZCTKIG (ORCPT ); Fri, 20 Mar 2009 06:08:06 -0400 Received: from www.tglx.de ([62.245.132.106]:59859 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760694AbZCTKIE (ORCPT ); Fri, 20 Mar 2009 06:08:04 -0400 Date: Fri, 20 Mar 2009 11:07:53 +0100 (CET) From: Thomas Gleixner To: Michal Simek cc: LKML , john.williams@petalogix.com, John Stultz Subject: Re: [PATCH 08/57] microblaze_v7: Interrupt handling, timer support, selfmod code In-Reply-To: <49C339EA.2070201@monstr.eu> Message-ID: References: <1237408284-8674-1-git-send-email-monstr@monstr.eu> <0168f03c96e9479ede695a9859c8a0691baa8ef3.1237407249.git.monstr@monstr.eu> <4b5aee01d11fc790c7842838ea63a82ee3273003.1237407249.git.monstr@monstr.eu> <5f8b2a60496983f572ef6d3b4e2f986c167a8336.1237407249.git.monstr@monstr.eu> <20fd42a1e8837c7352d35d157aa3393e88152c32.1237407249.git.monstr@monstr.eu> <49C2AB09.9040300@monstr.eu> <49C339EA.2070201@monstr.eu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 31 On Fri, 20 Mar 2009, Michal Simek wrote: > > Well. Either you have one shot mode, then better make it work and > > useable or just remove the one shot support until you figure out how > > to do it. > > I don't have it - this feature is not there. There is only printk message in > set_mode function. > > What is the best timer implementation in kernel? (For inspiration) There is no best :) All timers have usualy some weird hardware constraints so that code is always ugly. But just as an example: static int lapic_next_event(unsigned long delta, struct clock_event_device *evt) { apic_write(APIC_TMICT, delta); return 0; } I think that's pretty close to your hardware. delta is the number of timer cycles until the next event. There is no other magic with the one shot mode :) Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/