Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756563AbZCTLJt (ORCPT ); Fri, 20 Mar 2009 07:09:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751622AbZCTLJk (ORCPT ); Fri, 20 Mar 2009 07:09:40 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:46708 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbZCTLJk (ORCPT ); Fri, 20 Mar 2009 07:09:40 -0400 Date: Fri, 20 Mar 2009 12:09:21 +0100 From: Ingo Molnar To: Li Zefan Cc: Jens Axboe , Arnaldo Carvalho de Melo , Steven Rostedt , Frederic Weisbecker , LKML Subject: Re: [PATCH 0/7] blktrace: various cleanups and fixes Message-ID: <20090320110921.GA10840@elte.hu> References: <49C2F599.3060306@cn.fujitsu.com> <20090320102058.GC6256@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090320102058.GC6256@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 38 * Ingo Molnar wrote: > > * Li Zefan wrote: > > > While trying to use blktrace in -tip tree, I encounted kernel NULL > > dereference, so I looked into the code, and then found some other > > bugs. > > > > This patchset is part 1, and I have some other pending fixes. > > > > Each patch is small and straightforward, and should be easy to review: > > > > [PATCH 1/7] blktrace: fix possible memory leak > > [PATCH 2/7] blktrace: make blk_tracer_enabled a bool flag > > [PATCH 3/7] blktrace: remove blk_probe_mutex > > [PATCH 4/7] blktrace: don't increase blk_probes_ref if failed to setup blk trace > > [PATCH 5/7] blktrace: report EBUSY correctly > > [PATCH 6/7] blktrace: remove sysfs_blk_trace_enable_show/store() > > [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk > > --- > > blktrace.c | 154 +++++++++++++++++-------------------------------------------- > > 1 file changed, 45 insertions(+), 109 deletions(-) > > > > Signed-off-by: Li Zefan > > Nice fixes. Applied to tip:tracing/blktrace, thanks! Which would go upstream in the .30 merge window (unless Jens or Steve objects of course). Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/