From: Paul Moore <paul.moore@hp.com>
Organization: Hewlett-Packard
To: Miloslav Trmac <mitr@redhat.com>
Subject: Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records
Date: Fri, 20 Mar 2009 09:51:25 -0400
User-Agent: KMail/1.11.1 (Linux/2.6.27-gentoo-r8; KDE/4.2.1; i686; ; )
Cc: viro <viro@zeniv.linux.org.uk>, Eric Paris <eparis@redhat.com>,
       "linux-kernel" <linux-kernel@vger.kernel.org>, linux-audit@redhat.com
References: <1666981128.1772561237539207343.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
In-Reply-To: <1666981128.1772561237539207343.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200903200951.25699.paul.moore@hp.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1157
Lines: 32

On Friday 20 March 2009 04:53:27 am Miloslav Trmac wrote:
> ----- "Paul Moore" <paul.moore@hp.com> wrote:
> > There are several audit experts which should review this code but two
> > things jumped out at me when glancing at your patch:
> >
> >  1. SELinux SIDs should not be recorded
>
> Almost all code that logs SELinux contexts in kernel/audit* does the same
> thing as this patch, falling back to a SID if it can't be converted to a
> string.

Ungh, that's ugly and questionably useful (I suppose I know why this is done) 
but if that convention then who am I to argue.

> >  2. From a SELinux/security point of view ttys are considered objects
> >     and their labels/contexts should be recorded with "obj=" not
> > "subj="
>
> The patch logs the context of the process, not of the TTY.

Okay, that is what I get for just glancing at patches and not looking at them 
closer :)

-- 
paul moore
linux @ hp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/