Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756557AbZCTOMj (ORCPT ); Fri, 20 Mar 2009 10:12:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753866AbZCTOMa (ORCPT ); Fri, 20 Mar 2009 10:12:30 -0400 Received: from www.tglx.de ([62.245.132.106]:43856 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbZCTOMa (ORCPT ); Fri, 20 Mar 2009 10:12:30 -0400 Date: Fri, 20 Mar 2009 15:12:18 +0100 (CET) From: Thomas Gleixner To: Michal Simek cc: LKML , john.williams@petalogix.com, John Stultz Subject: Re: [PATCH 08/57] microblaze_v7: Interrupt handling, timer support, selfmod code In-Reply-To: <49C3A346.5040202@monstr.eu> Message-ID: References: <1237408284-8674-1-git-send-email-monstr@monstr.eu> <0168f03c96e9479ede695a9859c8a0691baa8ef3.1237407249.git.monstr@monstr.eu> <4b5aee01d11fc790c7842838ea63a82ee3273003.1237407249.git.monstr@monstr.eu> <5f8b2a60496983f572ef6d3b4e2f986c167a8336.1237407249.git.monstr@monstr.eu> <20fd42a1e8837c7352d35d157aa3393e88152c32.1237407249.git.monstr@monstr.eu> <49C2AB09.9040300@monstr.eu> <49C3A346.5040202@monstr.eu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 29 Michal, On Fri, 20 Mar 2009, Michal Simek wrote: > > I guess the problem is in your chip->xxx functions. > > I fixed it. There were one additional line. > + I set GENERIC_HARDIRQS_NO__DO_IRQ=y. Cool. > BTW: Below is full chip description where function enable is unmask > and disable is mask. Do I have keep there enable and disable function pointers? > I commented them and works without them too. Right. The generic code does: if (!chip->enable) chip->enable = default_enable; if (!chip->disable) chip->disable = default_disable; Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/