Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757691AbZCTPJk (ORCPT ); Fri, 20 Mar 2009 11:09:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757586AbZCTPJ2 (ORCPT ); Fri, 20 Mar 2009 11:09:28 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:36409 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757542AbZCTPJ1 (ORCPT ); Fri, 20 Mar 2009 11:09:27 -0400 Date: Fri, 20 Mar 2009 11:06:46 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Mel Gorman cc: Linux Memory Management List , KOSAKI Motohiro , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra , Andrew Morton Subject: Re: [PATCH 08/25] Calculate the preferred zone for allocation only once In-Reply-To: <1237543392-11797-9-git-send-email-mel@csn.ul.ie> Message-ID: References: <1237543392-11797-1-git-send-email-mel@csn.ul.ie> <1237543392-11797-9-git-send-email-mel@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 623 Lines: 14 On Fri, 20 Mar 2009, Mel Gorman wrote: > get_page_from_freelist() can be called multiple times for an allocation. > Part of this calculates the preferred_zone which is the first usable > zone in the zonelist. This patch calculates preferred_zone once. Isnt this adding an additional pass over the zonelist? Maybe mitigaged by the first zone usually being the preferred zone. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/