Date: Sat, 21 Mar 2009 13:17:57 +0100
From: Arjan Opmeer <arjan@opmeer.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <20090321121757.GB24247@adopmeer.homeip.net>
References: <20090320053509.GA3633@adopmeer.homeip.net> <200903202246.37383.dmitry.torokhov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200903202246.37383.dmitry.torokhov@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Subject: Re: [PATCH] input: elantech.c provide a workaround for jumpy
	cursor on firmware 2.34
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1118
Lines: 29

On Fri, Mar 20, 2009 at 10:46:37PM -0700, Dmitry Torokhov wrote:
> On Thursday 19 March 2009 22:35:09 Arjan Opmeer wrote:
> >
> > +	if (etd->jumpy_cursor) {
> > +		/* Discard packets that are likely to have bogus coordinates */
> > +		if (fingers > old_fingers) {
> > +			elantech_debug("elantech.c: discarding packet\n");
> > +			goto discard_packet_v1;
> 
> Can we do this unconditionally for the v1 protocol and not have an extra
> konb?

That is of course possible, although I am not sure it will not have any
negative side effects.

> Do you have access to boxes with unbroken V1 to test?

Nope. I am sorry. I don't have access to any machine with an Elantech
touchpad after my laptop died. I am trying to give the best support I can by
using 'remote development' where users have to report and test changes to
the driver. As you can imagine it is slow going.


Arjan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/