Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758424AbZCUQly (ORCPT ); Sat, 21 Mar 2009 12:41:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753634AbZCUQlp (ORCPT ); Sat, 21 Mar 2009 12:41:45 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:59350 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753277AbZCUQlp (ORCPT ); Sat, 21 Mar 2009 12:41:45 -0400 Date: Sat, 21 Mar 2009 12:41:42 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ingo Molnar cc: Anton Vorontsov , Steven Rostedt , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: Fix TRACING_SUPPORT dependency In-Reply-To: <20090321163328.GH11183@elte.hu> Message-ID: References: <20090320150914.GA22769@oksana.dev.rtsoft.ru> <20090320190428.GD6224@elte.hu> <20090320193904.GA13707@oksana.dev.rtsoft.ru> <20090320195743.GA25147@elte.hu> <20090320202247.GA30654@oksana.dev.rtsoft.ru> <20090321161814.GC11183@elte.hu> <20090321163328.GH11183@elte.hu> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 38 On Sat, 21 Mar 2009, Ingo Molnar wrote: > > > > > > Hm, do all the tracers even compile on ppc32 with your patch? > > > > > > We had periodic build failures on weird, unmaintained architectures > > > that had no irqflags-tracing support and hence didnt know the > > > raw_irqs_save/restore primitives ... > > > > > > I'm not trying to make things more difficult for you (and we can > > > apply your patch if it builds fine and does not cause problems > > > elsewhere), but there were some real downsides to not having proper > > > irq APIs ... > > > > Note, the issue is not with the hooks into local_irq_save/restore, > > but with the entry.S code. That code is very sensitive where the > > irqs are enabled and disabled. > > i know. What i'm talking about is that non-lockdep architectures > have the habit of not defining raw_local_irq_save() - which the > tracing core relies on. Since we know that's not an issue with PPC32, perhaps we should add (I hate to do this)... depends on TRACE_IRQFLAGS_SUPPORT || PPC32 And document that the "|| PPC32" should go when PowerPC32 gets its act together. :-/ -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/