Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755089AbZCUU6b (ORCPT ); Sat, 21 Mar 2009 16:58:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753388AbZCUU6X (ORCPT ); Sat, 21 Mar 2009 16:58:23 -0400 Received: from mx2.redhat.com ([66.187.237.31]:57529 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752786AbZCUU6X (ORCPT ); Sat, 21 Mar 2009 16:58:23 -0400 Message-ID: <49C554F2.1030408@redhat.com> Date: Sat, 21 Mar 2009 16:58:26 -0400 From: Masami Hiramatsu User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Frederic Weisbecker CC: Ananth N Mavinakayanahalli , Ingo Molnar , Steven Rostedt , systemtap-ml , LKML , Jim Keniston Subject: Re: [RFC][PATCH -tip 4/5 V2] kprobes: support respawn probes for module probing References: <49C4440B.8030300@redhat.com> <20090321020044.GE6044@nowhere> In-Reply-To: <20090321020044.GE6044@nowhere> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 37 Frederic Weisbecker wrote: > On Fri, Mar 20, 2009 at 09:34:03PM -0400, Masami Hiramatsu wrote: [...] >> +static int add_module_probe(const char *module, void *p, enum probe_type type, >> + probe_activate_handler_t handler, void *data) >> +{ >> + struct module_probe_client *pc; >> + int ret = 0; >> + >> + if (!handler) >> + return -EINVAL; >> + >> + pc = kzalloc(sizeof(struct module_probe_client), GFP_KERNEL); > > > You forgot something here. Right? ;-) Oops, sure... Thank you! -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/