Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755822AbZCUWq1 (ORCPT ); Sat, 21 Mar 2009 18:46:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754396AbZCUWqQ (ORCPT ); Sat, 21 Mar 2009 18:46:16 -0400 Received: from wf-out-1314.google.com ([209.85.200.174]:31900 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752928AbZCUWqP (ORCPT ); Sat, 21 Mar 2009 18:46:15 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=cbk6xtAW6Oj1vZkeXOLt4L+Im8zE+WmpGtm8F4Of6VB+SpDqozmD+mQq3HGiEkWQrl +lDxuDs1gCKK279tWURTpvwn01fhgr1MZ5jUKfswuxGufOfYLxASNdaKUJPcJH0oSMLR 49wjL2kXnkUO6kn0q443UINK1CTHE7tWgfDCM= MIME-Version: 1.0 In-Reply-To: <49C5699C.8050405@emcraft.com> References: <20090318191248.20375.40560.stgit@dwillia2-linux.ch.intel.com> <49C41C1E.4060401@zytor.com> <49C4201A.5060905@emcraft.com> <49C425F5.8060309@intel.com> <49C42F99.5010700@emcraft.com> <49C45159.8020503@zytor.com> <49C53CC0.5060303@zytor.com> <49C5699C.8050405@emcraft.com> Date: Sat, 21 Mar 2009 15:46:12 -0700 X-Google-Sender-Auth: 8e31a0f9dc95ff10 Message-ID: Subject: Re: [PATCH 06/13] async_tx: add support for asynchronous GF multiplication From: Dan Williams To: Ilya Yanok Cc: "H. Peter Anvin" , "H. Peter Anvin" , "linux-raid@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "neilb@suse.de" , "Sosnowski, Maciej" , Yuri Tikhonov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 20 On Sat, Mar 21, 2009 at 3:26 PM, Ilya Yanok wrote: >> The caller needs to be modified to only require scalar multiplication >> even in this corner case. >> > > Argh... There is no vector-vector multiplication at all! You just need > to swap the 'for' cycles back (as it was in the original patch by me and > Yuri) to get rid of two-dimensional lookup at each step. Yes, I swapped the loops as part of the removal of the ASYNC_TX_ZERO_{P,Q} flags and wanted to avoid an explicit memset. I'll rework this path... Regards, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/