Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbZCVOah (ORCPT ); Sun, 22 Mar 2009 10:30:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752224AbZCVOa1 (ORCPT ); Sun, 22 Mar 2009 10:30:27 -0400 Received: from 82-117-125-11.tcdsl.calypso.net ([82.117.125.11]:39312 "EHLO smtp.ossman.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbZCVOa0 (ORCPT ); Sun, 22 Mar 2009 10:30:26 -0400 Date: Sun, 22 Mar 2009 15:30:19 +0100 From: Pierre Ossman To: Adrian Hunter Cc: Jarkko Lavinen , Adrian Hunter , Grazvydas Ignotas , David Brownell , linux-omap Mailing List , Tony Lindgren , lkml Subject: Re: [PATCH 8/10] OMAP: HSMMC: Make driver support dynamic idle Message-ID: <20090322153019.2ae32458@mjolnir.ossman.eu> In-Reply-To: <20090312162346.19421.90213.sendpatchset@ahunter-laptop> References: <20090312162252.19421.34019.sendpatchset@ahunter-laptop> <20090312162346.19421.90213.sendpatchset@ahunter-laptop> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.15.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 39 On Thu, 12 Mar 2009 18:23:46 +0200 Adrian Hunter wrote: > From 47b6de0fcfeb5948199dbed941847580bedc5315 Mon Sep 17 00:00:00 2001 > From: Amit Kucheria > Date: Thu, 12 Mar 2009 15:47:39 +0200 > Subject: [PATCH] OMAP: HSMMC: Make driver support dynamic idle > > Add a timer that is kept active by MMC requests. FCLK is disabled on > timeout. > > Signed-off-by: Amit Kucheria > Signed-off-by: Jarkko Lavinen > Signed-off-by: Adrian Hunter > --- NAK. This should be implemented in the core where we get a consistent behaviour across all hosts. The principle with a timeout is sound though. As for the current state of the driver, stop fiddling with the clock when it isn't necessary. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/