Date: Sun, 22 Mar 2009 20:56:24 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Steven Rostedt <rostedt@goodmis.org>,
       =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 0/4] tracing: event filtering v2
Message-ID: <20090322195624.GC15002@elte.hu>
References: <1237710626.7703.45.camel@charm-linux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1237710626.7703.45.camel@charm-linux>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1378
Lines: 36


* Tom Zanussi <tzanussi@gmail.com> wrote:

> Hi,
> 
> This is version 2 of my patchset adding filtering to the 
> event-tracing infrastructure.
> 
> Changes from the previous version:
> 
> - added common_ prefix to the 5 common event fields
> - ring_buffer_event_discard() fixes from Steven Rostedt
> - changed 'and' and 'or' for compound filters to '&&' and '||'
> - fixed a bug in the matching logic 
> 
> Everything seems to work ok for me, but I haven't yet gotten 
> around to changing the awkward UI.  I plan to fix that as soon as 
> I can i.e. allow complete compound expressions to be specified all 
> at once, add <, >, <=, >= and parens, etc.  Until then, it should 
> hopefully be usable for basic filtering.

Thanks Tom - Frederic and me had a good look and i picked them up 
into tip:tracing/filters for now and lets see how they hold up in 
testing. There was one boundary-condition bug Frederic noticed, i 
fixed that.

The subsystem level filters are a nice touch. We still have to 
complete and organize events into a comprehensive, Linux-wide set of 
tracepoints, so there will be some churn in this area.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/