Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756635AbZCVXNR (ORCPT ); Sun, 22 Mar 2009 19:13:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756515AbZCVXM7 (ORCPT ); Sun, 22 Mar 2009 19:12:59 -0400 Received: from mail.crca.org.au ([67.207.131.56]:53266 "EHLO crca.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756498AbZCVXM7 (ORCPT ); Sun, 22 Mar 2009 19:12:59 -0400 X-Greylist: delayed 446 seconds by postgrey-1.27 at vger.kernel.org; Sun, 22 Mar 2009 19:12:58 EDT X-Bogosity: Ham, spamicity=0.000000 Subject: Re: [linux-pm] [RFC][PATCH 1/2] PCI PM: Introduce __pci_set_power_state() From: Nigel Cunningham Reply-To: nigel@tuxonice.net To: "Rafael J. Wysocki" Cc: Jesse Barnes , Benjamin Herrenschmidt , Linux PCI , pm list , Linus Torvalds , LKML , Andrew Morton In-Reply-To: <200903222211.50930.rjw@sisk.pl> References: <200903210003.55161.rjw@sisk.pl> <200903222208.22434.rjw@sisk.pl> <200903222211.50930.rjw@sisk.pl> Content-Type: text/plain Date: Mon, 23 Mar 2009 10:08:05 +1100 Message-Id: <1237763285.11186.2.camel@nigel-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 459 Lines: 17 Hi. It's not an error if we fail to set the desired state? (I see you have a dev_warn only). (If it is an error, the radeon_set_suspend patch needs to be adjusted to not ignore the error code). Regards, Nigel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/