Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757162AbZCWAo4 (ORCPT ); Sun, 22 Mar 2009 20:44:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754137AbZCWAop (ORCPT ); Sun, 22 Mar 2009 20:44:45 -0400 Received: from wf-out-1314.google.com ([209.85.200.173]:1145 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbZCWAoo convert rfc822-to-8bit (ORCPT ); Sun, 22 Mar 2009 20:44:44 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=K0ZEF5jGQuXzIyihTpXUoOJvpAL2y1rLVPSkvlHJuYIqPXFNFZUU7PhJlxY4IM6SSv CjGPTb3ynk5bqE8rxhhYMHuCpHetCe3hG76WAv9dWu46TJKAAT1y5seD/hSDqtKmgY2V /o9XayJ5omguQ+qqsZNSXNs2sd2oLtvr0akMg= MIME-Version: 1.0 In-Reply-To: <1237752784-1989-3-git-send-email-hannes@cmpxchg.org> References: <20090321102044.GA3427@cmpxchg.org> <1237752784-1989-3-git-send-email-hannes@cmpxchg.org> Date: Mon, 23 Mar 2009 09:44:42 +0900 Message-ID: <28c262360903221744r6d275294gdc8ad3a12b8c5361@mail.gmail.com> Subject: Re: [patch 3/3] mm: keep pages from unevictable mappings off the LRU lists From: Minchan Kim To: Johannes Weiner Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Howells , Nick Piggin , KOSAKI Motohiro , Rik van Riel , Peter Zijlstra , Lee Schermerhorn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2552 Lines: 70 Hmm,, This patch is another thing unlike previous series patches. Firstly, It looked good to me. I think add_to_page_cache_lru have to become a fast path. But, how often would ramfs and shmem function be called ? I have a concern for this patch to add another burden. so, we need any numbers for getting pros and cons. Any thoughts ? On Mon, Mar 23, 2009 at 5:13 AM, Johannes Weiner wrote: > Check if the mapping is evictable when initially adding page cache > pages to the LRU lists.  If that is not the case, add them to the > unevictable list immediately instead of leaving it up to the reclaim > code to move them there. > > This is useful for ramfs and locked shmem which mark whole mappings as > unevictable and we know at fault time already that it is useless to > try reclaiming these pages. > > Signed-off-by: Johannes Weiner > Cc: David Howells > Cc: Nick Piggin > Cc: KOSAKI Motohiro > Cc: Rik van Riel > Cc: Peter Zijlstra > Cc: MinChan Kim > Cc: Lee Schermerhorn > --- >  mm/filemap.c |    4 +++- >  1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 23acefe..8574530 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -506,7 +506,9 @@ int add_to_page_cache_lru(struct page *page, struct address_space *mapping, > >        ret = add_to_page_cache(page, mapping, offset, gfp_mask); >        if (ret == 0) { > -               if (page_is_file_cache(page)) > +               if (mapping_unevictable(mapping)) > +                       add_page_to_unevictable_list(page); > +               else if (page_is_file_cache(page)) >                        lru_cache_add_file(page); >                else >                        lru_cache_add_active_anon(page); > -- > 1.6.2.1.135.gde769 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org.  For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- Kinds regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/