Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755105AbZCWCXV (ORCPT ); Sun, 22 Mar 2009 22:23:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752098AbZCWCXH (ORCPT ); Sun, 22 Mar 2009 22:23:07 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:56025 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbZCWCXG (ORCPT ); Sun, 22 Mar 2009 22:23:06 -0400 From: KOSAKI Motohiro To: Johannes Weiner Subject: Re: [patch 2/3] ramfs-nommu: use generic lru cache Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Howells , Nick Piggin , Rik van Riel , Peter Zijlstra , MinChan Kim , Lee Schermerhorn In-Reply-To: <1237752784-1989-2-git-send-email-hannes@cmpxchg.org> References: <20090321102044.GA3427@cmpxchg.org> <1237752784-1989-2-git-send-email-hannes@cmpxchg.org> Message-Id: <20090323112219.69F6.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50 [ja] Date: Mon, 23 Mar 2009 11:22:59 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 590 Lines: 16 > Instead of open-coding the lru-list-add pagevec batching when > expanding a file mapping from zero, defer to the appropriate page > cache function that also takes care of adding the page to the lru > list. > > This is cleaner, saves code and reduces the stack footprint by 16 > words worth of pagevec. Looks good to me. thanks good patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/