Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756856AbZCWIP3 (ORCPT ); Mon, 23 Mar 2009 04:15:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755134AbZCWIPN (ORCPT ); Mon, 23 Mar 2009 04:15:13 -0400 Received: from ozlabs.org ([203.10.76.45]:52493 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754917AbZCWIPL (ORCPT ); Mon, 23 Mar 2009 04:15:11 -0400 From: Rusty Russell To: Jaswinder Singh Rajput Subject: Re: [git-pull -tip] x86: cleanup patches 20090322 Date: Mon, 23 Mar 2009 18:45:04 +1030 User-Agent: KMail/1.11.1 (Linux/2.6.27-11-generic; KDE/4.2.1; i686; ; ) Cc: Ingo Molnar , x86 maintainers , Sam Ravnborg , Yinghai Lu , LKML References: <1237755176.5417.16.camel@ht.satnam> In-Reply-To: <1237755176.5417.16.camel@ht.satnam> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903231845.05394.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 668 Lines: 21 On Monday 23 March 2009 07:22:56 Jaswinder Singh Rajput wrote: > x86: e820.h fix various signedness issues in setup.c and e820.c Wouldn't fixing the users be better than changing the header? Esp. since it could well now cause similar warnings in userspace programs. > struct e820map { > - __u32 nr_map; > + __s32 nr_map; > struct e820entry map[E820_X_MAX]; > }; This number can't be negative! Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/