Date: Mon, 23 Mar 2009 09:33:33 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Tom Zanussi <tzanussi@gmail.com>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       Steven Rostedt <rostedt@goodmis.org>,
       =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] tracing/filters: use list_for_each_entry_safe
Message-ID: <20090323083333.GD18837@elte.hu>
References: <1237796788.7527.35.camel@charm-linux> <49C748B0.20305@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49C748B0.20305@cn.fujitsu.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 836
Lines: 26


* Li Zefan <lizf@cn.fujitsu.com> wrote:

> > -	list_for_each_safe(entry, tmp, &call->fields) {
> > -		field = list_entry(entry, struct ftrace_event_field, link);
> > +	list_for_each_entry_safe(field, next, &call->fields, link) {
> 
> Why we need _safe version ?

indeed the plain list_for_each_entry() variant would be fine, as the 
list is only walked, not modified:

> >  		if (!strcmp(field->name, name))
> >  			return field;
> >  	}

(I've applied this patch already as it was a step forward - so 
please enhance this in the next round of cleanups via a delta patch 
- thanks!)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/