Date: Mon, 23 Mar 2009 18:15:36 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
       rostedt@goodmis.org, tglx@linutronix.de, daniel@caiaq.de,
       linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/ftrace] kernel/trace/trace_functions_graph.c: fix
	nsecs_str buffer size
Message-ID: <20090323171536.GA6848@elte.hu>
References: <1237824637-28190-1-git-send-email-daniel@caiaq.de> <tip-603b9b9081ae0a1af986b9059a0a5055876ddea9@git.kernel.org> <20090323164745.GB5988@nowhere>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090323164745.GB5988@nowhere>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1734
Lines: 48


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> On Mon, Mar 23, 2009 at 04:42:27PM +0000, Daniel Mack wrote:
> > Commit-ID:  603b9b9081ae0a1af986b9059a0a5055876ddea9
> > Gitweb:     http://git.kernel.org/tip/603b9b9081ae0a1af986b9059a0a5055876ddea9
> > Author:     Daniel Mack <daniel@caiaq.de>
> > AuthorDate: Mon, 23 Mar 2009 17:10:37 +0100
> > Committer:  Ingo Molnar <mingo@elte.hu>
> > CommitDate: Mon, 23 Mar 2009 17:40:51 +0100
> > 
> > kernel/trace/trace_functions_graph.c: fix nsecs_str buffer size
> > 
> > Impact: fix currently inactive buffer-overflow
> > 
> > In kernel/trace/trace_functions_graph.c, print_graph_duration(),
> > len can be as low as 1 or 2, which could make snprintf() write
> > beyond the buffer bounds. (Found by cppcheck, no real-world bug
> > occured)
> > 
> > Signed-off-by: Daniel Mack <daniel@caiaq.de>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > LKML-Reference: <1237824637-28190-1-git-send-email-daniel@caiaq.de>
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > 
> > 
> > ---
> >  kernel/trace/trace_functions_graph.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> 
> Ingo, as I explained to Daniel before (I should have Cc you),
> there is no overflow to protect here, so this patch will not
> change anything.
> 
> This is my bad, I should better comment my code.

Yeah - saw your reply, and zapped the commit already. Please add a 
comment in any case.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/