Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760240AbZCWSJ5 (ORCPT ); Mon, 23 Mar 2009 14:09:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755583AbZCWSJo (ORCPT ); Mon, 23 Mar 2009 14:09:44 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:45252 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755028AbZCWSJn (ORCPT ); Mon, 23 Mar 2009 14:09:43 -0400 Date: Mon, 23 Mar 2009 14:06:18 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Pekka Enberg cc: Ingo Molnar , Lai Jiangshan , Andrew Morton , Nick Piggin , "Paul E. McKenney" , Manfred Spraul , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm 1/6] slab: introduce __kfree_rcu In-Reply-To: <84144f020903231049o11de5287w7bdb5c28e866dafb@mail.gmail.com> Message-ID: References: <49AD3433.9000001@cn.fujitsu.com> <1237794502.6313.21.camel@penberg-laptop> <20090323155938.GA27151@elte.hu> <20090323165639.GA6841@elte.hu> <84144f020903231049o11de5287w7bdb5c28e866dafb@mail.gmail.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 21 On Mon, 23 Mar 2009, Pekka Enberg wrote: > Well, like I said, it was a minor nitpick, that's all. I would prefer > it the way I and Ingo suggested but if you don't want to change it, > that's fine as well. Maybe put some macros in to make these "pickup the context" thingies more readable. Or would a macro obfuscate things? #define GET_SLAB_CONTEXT(pointer, slab, cache, page) and #define GET_OBJECT_CONTEXT(pointer, slab, index, offset) ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/