Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756759AbZCXIaT (ORCPT ); Tue, 24 Mar 2009 04:30:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754708AbZCXIaB (ORCPT ); Tue, 24 Mar 2009 04:30:01 -0400 Received: from fg-out-1718.google.com ([72.14.220.152]:57094 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168AbZCXI37 (ORCPT ); Tue, 24 Mar 2009 04:29:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=cIm0dElq0HcVny3+r459tD/SqrClaHqAaX2ZQE8NIDaI9Poi2Nou5z5PYblr+HL9KY kgJiF0qemugG0O3nSwwy59Z1rB5dzyTUl6QBWMmlue/dgJFjgWGYQRS4QO1NIFkKm6gv Nc7LS3rlDVphojXSCWNnoKk/X1qRwmh+cW6+s= Date: Tue, 24 Mar 2009 10:30:32 +0200 From: Eduard - Gabriel Munteanu To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, penberg@cs.helsinki.fi, tglx@linutronix.de, mingo@elte.hu Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:tracing/kmemtrace] kmemtrace: fix tracepoint declarations Message-ID: <20090324083032.GA5383@localhost> References: <1237882470.25315.30.camel@penberg-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3487 Lines: 94 On Tue, Mar 24, 2009 at 08:21:28AM +0000, Pekka Enberg wrote: > Commit-ID: 9d47aa18654e4344b1d20b14463addee676e9ea4 > Gitweb: http://git.kernel.org/tip/9d47aa18654e4344b1d20b14463addee676e9ea4 > Author: Pekka Enberg > AuthorDate: Tue, 24 Mar 2009 10:14:30 +0200 > Committer: Ingo Molnar > CommitDate: Tue, 24 Mar 2009 09:19:52 +0100 > > kmemtrace: fix tracepoint declarations > > Impact: build fix > > Use the new TP_PROTO and TP_ARGS to fix the build. > > Signed-off-by: Pekka Enberg > Cc: Eduard - Gabriel Munteanu > LKML-Reference: <1237882470.25315.30.camel@penberg-laptop> > Signed-off-by: Ingo Molnar > > > --- > include/trace/kmemtrace.h | 24 ++++++++++++------------ > 1 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/include/trace/kmemtrace.h b/include/trace/kmemtrace.h > index 9e28ae1..7514476 100644 > --- a/include/trace/kmemtrace.h > +++ b/include/trace/kmemtrace.h > @@ -15,41 +15,41 @@ > extern void kmemtrace_init(void); > > DECLARE_TRACE(kmalloc, > - TPPROTO(unsigned long call_site, > + TP_PROTO(unsigned long call_site, > const void *ptr, > size_t bytes_req, > size_t bytes_alloc, > gfp_t gfp_flags), > - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags)); > + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags)); > DECLARE_TRACE(kmem_cache_alloc, > - TPPROTO(unsigned long call_site, > + TP_PROTO(unsigned long call_site, > const void *ptr, > size_t bytes_req, > size_t bytes_alloc, > gfp_t gfp_flags), > - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags)); > + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags)); > DECLARE_TRACE(kmalloc_node, > - TPPROTO(unsigned long call_site, > + TP_PROTO(unsigned long call_site, > const void *ptr, > size_t bytes_req, > size_t bytes_alloc, > gfp_t gfp_flags, > int node), > - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node)); > + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node)); > DECLARE_TRACE(kmem_cache_alloc_node, > - TPPROTO(unsigned long call_site, > + TP_PROTO(unsigned long call_site, > const void *ptr, > size_t bytes_req, > size_t bytes_alloc, > gfp_t gfp_flags, > int node), > - TPARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node)); > + TP_ARGS(call_site, ptr, bytes_req, bytes_alloc, gfp_flags, node)); > DECLARE_TRACE(kfree, > - TPPROTO(unsigned long call_site, const void *ptr), > - TPARGS(call_site, ptr)); > + TP_PROTO(unsigned long call_site, const void *ptr), > + TP_ARGS(call_site, ptr)); > DECLARE_TRACE(kmem_cache_free, > - TPPROTO(unsigned long call_site, const void *ptr), > - TPARGS(call_site, ptr)); > + TP_PROTO(unsigned long call_site, const void *ptr), > + TP_ARGS(call_site, ptr)); > > #endif /* __KERNEL__ */ > Thanks, I was clueless. I thought the problem was similar to the RCU stuff. Eduard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/