Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757809AbZCXIof (ORCPT ); Tue, 24 Mar 2009 04:44:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756072AbZCXIoZ (ORCPT ); Tue, 24 Mar 2009 04:44:25 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:59366 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbZCXIoY (ORCPT ); Tue, 24 Mar 2009 04:44:24 -0400 Date: Tue, 24 Mar 2009 09:44:04 +0100 From: Ingo Molnar To: Li Zefan Cc: Jens Axboe , Steven Rostedt , Frederic Weisbecker , Arnaldo Carvalho de Melo , LKML Subject: Re: [PATCH 4/5] blktrace: fix t_error() Message-ID: <20090324084404.GD13016@elte.hu> References: <49C893FC.9080905@cn.fujitsu.com> <49C8945F.5020802@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49C8945F.5020802@cn.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 14 * Li Zefan wrote: > t_error() should return t->error but not t->sector. Nice. This bug got introduced by the blktrace->ftrace conversion. Old blktrace passed t->error straight to user-space. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/