Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757603AbZCXIyU (ORCPT ); Tue, 24 Mar 2009 04:54:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754833AbZCXIyL (ORCPT ); Tue, 24 Mar 2009 04:54:11 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:53006 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754441AbZCXIyJ (ORCPT ); Tue, 24 Mar 2009 04:54:09 -0400 Subject: Re: [PATCH] kmemtrace: fix build breakage in befs From: Pekka Enberg To: Ingo Molnar Cc: eduard.munteanu@linux360.ro, linux-kernel@vger.kernel.org In-Reply-To: <20090324085128.GF13016@elte.hu> References: <1237884230.25315.33.camel@penberg-laptop> <20090324085128.GF13016@elte.hu> Date: Tue, 24 Mar 2009 10:54:06 +0200 Message-Id: <1237884846.25315.37.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Mailer: Evolution 2.22.3.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 21 On Tue, 2009-03-24 at 09:51 +0100, Ingo Molnar wrote: > there's another build problem as well, in squashfs, and in key.h: > > include/linux/key.h:128: error: field 'sem' has incomplete type > fs/squashfs/export.c:133: error: implicit declaration of function 'kmalloc' > fs/squashfs/export.c:143: error: implicit declaration of function 'kfree' > > And i suspect there's more as well. Is there really no unintrusive > way to solve this - or do you think the RCU change reduces the > include file spaghetti? I don't think there is and yes, I do think the RCU change cleans up things as well. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/