Date: Tue, 24 Mar 2009 09:56:58 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: eduard.munteanu@linux360.ro, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmemtrace: fix build breakage in befs
Message-ID: <20090324085658.GG13016@elte.hu>
References: <1237884230.25315.33.camel@penberg-laptop> <20090324085128.GF13016@elte.hu> <1237884846.25315.37.camel@penberg-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1237884846.25315.37.camel@penberg-laptop>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 27


* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Tue, 2009-03-24 at 09:51 +0100, Ingo Molnar wrote:
> > there's another build problem as well, in squashfs, and in key.h:
> > 
> >  include/linux/key.h:128: error: field 'sem' has incomplete type
> >  fs/squashfs/export.c:133: error: implicit declaration of function 'kmalloc'
> >  fs/squashfs/export.c:143: error: implicit declaration of function 'kfree'
> > 
> > And i suspect there's more as well. Is there really no unintrusive 
> > way to solve this - or do you think the RCU change reduces the 
> > include file spaghetti?
> 
> I don't think there is and yes, I do think the RCU change cleans 
> up things as well.

Okay. Note, you'll have to test tip:tracing/kmemtrace explicitly as 
i had to exclude it from tip:master due to test failures. Will put 
it back in once fixes arrive :)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/