Date: Tue, 24 Mar 2009 12:04:43 -0400 (EDT)
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
cc: Li Zefan <lizf@cn.fujitsu.com>, Jens Axboe <jens.axboe@oracle.com>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Arnaldo Carvalho de Melo <acme@redhat.com>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] blktrace: print human-readable act_mask
In-Reply-To: <20090324155609.GA10365@elte.hu>
Message-ID: <alpine.DEB.2.00.0903241202440.22830@gandalf.stny.rr.com>
References: <49C893FC.9080905@cn.fujitsu.com> <49C89488.4030604@cn.fujitsu.com> <alpine.DEB.2.00.0903241148240.22830@gandalf.stny.rr.com> <20090324155609.GA10365@elte.hu>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 41


On Tue, 24 Mar 2009, Ingo Molnar wrote:

> 
> * Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > 
> > 
> > On Tue, 24 Mar 2009, Li Zefan wrote:
> > >  
> > > +static ssize_t blk_trace_mask2str(char *buf, int mask)

> > >  	else if (attr == &dev_attr_act_mask)
> > > -		ret = sprintf(buf, "%#x\n", q->blk_trace->act_mask);
> > > +		ret = blk_trace_mask2str(buf, q->blk_trace->act_mask);


> > > -			value = blk_str2act_mask(buf);
> > > -			if (value < 0)
> > > +			value = blk_trace_str2mask(buf);
> > 
> > Hmm, does this compile? Doesn't blk_trace_str2mask need two parameters?
> 
> No, it needs one parameter.

I'm really confused now. The prototype for blk_trace_str2mask has 
two parameters. It is used with two parameters above, but then it is used 
here with only one parameter. The blk_str2act_mask may have one, and that 
is what is replaced.

What am I missing?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/