Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762180AbZCXQG0 (ORCPT ); Tue, 24 Mar 2009 12:06:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755825AbZCXQGR (ORCPT ); Tue, 24 Mar 2009 12:06:17 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:42202 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753214AbZCXQGQ (ORCPT ); Tue, 24 Mar 2009 12:06:16 -0400 Date: Tue, 24 Mar 2009 12:06:14 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ingo Molnar cc: Li Zefan , Jens Axboe , Frederic Weisbecker , Arnaldo Carvalho de Melo , LKML Subject: Re: [PATCH 5/5] blktrace: print human-readable act_mask In-Reply-To: Message-ID: References: <49C893FC.9080905@cn.fujitsu.com> <49C89488.4030604@cn.fujitsu.com> <20090324155609.GA10365@elte.hu> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 54 On Tue, 24 Mar 2009, Steven Rostedt wrote: > > > > On Tue, 24 Mar 2009, Ingo Molnar wrote: > > > > > * Steven Rostedt wrote: > > > > > > > > > > > On Tue, 24 Mar 2009, Li Zefan wrote: > > > > > > > > +static ssize_t blk_trace_mask2str(char *buf, int mask) > > > > > else if (attr == &dev_attr_act_mask) > > > > - ret = sprintf(buf, "%#x\n", q->blk_trace->act_mask); > > > > + ret = blk_trace_mask2str(buf, q->blk_trace->act_mask); > > > > > > - value = blk_str2act_mask(buf); > > > > - if (value < 0) > > > > + value = blk_trace_str2mask(buf); > > > > > > Hmm, does this compile? Doesn't blk_trace_str2mask need two parameters? > > > > No, it needs one parameter. > > I'm really confused now. The prototype for blk_trace_str2mask has > two parameters. It is used with two parameters above, but then it is used > here with only one parameter. The blk_str2act_mask may have one, and that > is what is replaced. > > What am I missing? I'm dyslexic :-p I see now... The proto-type is blk_trace_mask2str but this is blk_trace_str2mask Nevermind, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/